Optimize memtable region scan #16883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16883 +/- ##
============================================
+ Coverage 38.87% 38.93% +0.06%
Complexity 207 207
============================================
Files 5022 5035 +13
Lines 333113 334139 +1026
Branches 42390 42540 +150
============================================
+ Hits 129487 130104 +617
- Misses 203626 204035 +409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
JackieTien97
approved these changes
Dec 9, 2025
shuwenwei
added a commit
that referenced
this pull request
Dec 10, 2025
JackieTien97
pushed a commit
that referenced
this pull request
Dec 10, 2025
(cherry picked from commit a899c48)
JackieTien97
pushed a commit
that referenced
this pull request
Dec 11, 2025
(cherry picked from commit a899c48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize memtable region scan
Test
300W rows in writableMemChunk. Call writableMemChunk.getAnySatisfiedTimestamp for 10 times and print the cost
before this optimization:
the slowest case(The condition is met only in the last row of the tvlist) after this optimization: