-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[AINode] More strict concurrent inference IT #16898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR rectifies the judgment logic of the AINode concurrent inference test by improving error detection and reporting in multi-threaded test scenarios. The changes address two key issues: updating the SQL parameter name from forecast_length to output_length to match the correct API, and replacing immediate assertions with a flag-based approach to capture failures across all concurrent threads.
- Introduced
AtomicBooleanflag to track test failures across multiple threads - Replaced immediate
assertEqualswith deferred failure detection via theallPassflag - Updated FORECAST function parameter from
forecast_lengthtooutput_length
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java | Modified concurrent test utility to use AtomicBoolean for tracking failures across threads, added assertion after thread completion, and set flag on exceptions |
| integration-test/src/test/java/org/apache/iotdb/ainode/it/AINodeConcurrentForecastIT.java | Fixed SQL template parameter name from forecast_length to output_length |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java
Show resolved
Hide resolved
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16898 +/- ##
=========================================
Coverage 39.02% 39.02%
Complexity 207 207
=========================================
Files 5021 5021
Lines 333373 333378 +5
Branches 42431 42431
=========================================
+ Hits 130107 130110 +3
- Misses 203266 203268 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Rectify the judgement logic of AINode concurrent inference test.