Skip to content

Conversation

@CRZbulabula
Copy link
Contributor

Rectify the judgement logic of AINode concurrent inference test.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rectifies the judgment logic of the AINode concurrent inference test by improving error detection and reporting in multi-threaded test scenarios. The changes address two key issues: updating the SQL parameter name from forecast_length to output_length to match the correct API, and replacing immediate assertions with a flag-based approach to capture failures across all concurrent threads.

  • Introduced AtomicBoolean flag to track test failures across multiple threads
  • Replaced immediate assertEquals with deferred failure detection via the allPass flag
  • Updated FORECAST function parameter from forecast_length to output_length

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java Modified concurrent test utility to use AtomicBoolean for tracking failures across threads, added assertion after thread completion, and set flag on exceptions
integration-test/src/test/java/org/apache/iotdb/ainode/it/AINodeConcurrentForecastIT.java Fixed SQL template parameter name from forecast_length to output_length

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.02%. Comparing base (c722aaf) to head (e03eee1).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16898   +/-   ##
=========================================
  Coverage     39.02%   39.02%           
  Complexity      207      207           
=========================================
  Files          5021     5021           
  Lines        333373   333378    +5     
  Branches      42431    42431           
=========================================
+ Hits         130107   130110    +3     
- Misses       203266   203268    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@CRZbulabula CRZbulabula merged commit 7c7b2a6 into master Dec 12, 2025
32 checks passed
@CRZbulabula CRZbulabula deleted the bug-fix-ain branch December 12, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant