Skip to content

delete audit implementation #16899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CRZbulabula merged 2 commits into from
Dec 12, 2025
Merged

delete audit implementation #16899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e35ae
delete audit implementation
zhujt20 Dec 11, 2025
b6c8f34
do not import *
zhujt20 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration-test/src/test/java/org/apache/iotdb/db/it/audit/IoTDBAuditLogBasicIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
Expand All @@ -52,6 +53,7 @@
* This test class ensures the audit log behave exactly the same as we expected, including the
* number, sequence and content of the audit logs.
*/
@Ignore
@RunWith(IoTDBTestRunner.class)
@Category({LocalStandaloneIT.class})
public class IoTDBAuditLogBasicIT {
Expand Down
50 changes: 1 addition & 49 deletions iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/audit/CNAuditLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,16 @@

package org.apache.iotdb.confignode.audit;

import org.apache.iotdb.common.rpc.thrift.TConsensusGroupId;
import org.apache.iotdb.common.rpc.thrift.TConsensusGroupType;
import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet;
import org.apache.iotdb.commons.audit.AbstractAuditLogger;
import org.apache.iotdb.commons.audit.IAuditEntity;
import org.apache.iotdb.confignode.client.async.AsyncDataNodeHeartbeatClientPool;
import org.apache.iotdb.confignode.client.async.handlers.audit.DataNodeWriteAuditLogHandler;
import org.apache.iotdb.confignode.conf.ConfigNodeConfig;
import org.apache.iotdb.confignode.conf.ConfigNodeDescriptor;
import org.apache.iotdb.confignode.manager.ConfigManager;
import org.apache.iotdb.confignode.manager.IManager;
import org.apache.iotdb.mpp.rpc.thrift.TAuditLogReq;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.List;
import java.util.function.Supplier;

public class CNAuditLogger extends AbstractAuditLogger {
Expand All @@ -50,45 +42,5 @@ public CNAuditLogger(ConfigManager configManager) {
}

@Override
public void log(IAuditEntity auditLogFields, Supplier<String> log) {
if (!IS_AUDIT_LOG_ENABLED) {
return;
}
if (noNeedInsertAuditLog(auditLogFields)) {
return;
}
// find database "__audit"'s data_region
List<TRegionReplicaSet> auditReplicaSets =
configManager
.getPartitionManager()
.getAllReplicaSets("root.__audit", TConsensusGroupType.DataRegion);
if (auditReplicaSets.isEmpty()) {
logger.warn("Database {} does not exist.", "root.__audit");
return;
}
TConsensusGroupId regionId = auditReplicaSets.get(0).getRegionId();
// use ConfigManager.getLoadManager().getLoadCache().getRegionLeaderMap() to get regionLeaderId
TDataNodeLocation regionLeader = configManager.getRegionLeaderLocation(regionId);
TAuditLogReq req =
new TAuditLogReq(
auditLogFields.getUsername(),
auditLogFields.getUserId(),
auditLogFields.getCliHostname(),
auditLogFields.getAuditEventType().toString(),
auditLogFields.getAuditLogOperation().toString(),
auditLogFields.getPrivilegeTypeString(),
auditLogFields.getResult(),
auditLogFields.getDatabase(),
auditLogFields.getSqlString(),
log.get(),
CONF.getConfigNodeId());
// refer the implementation of HeartbeatService.pingRegisteredDataNode(). By appending a new
// writeAudtiLog() interface in AsyncDataNodeHeartbeatClientPool, the main thread is not
// required to wait until the write audit log request to be complete.
AsyncDataNodeHeartbeatClientPool.getInstance()
.writeAuditLog(
regionLeader.getInternalEndPoint(),
req,
new DataNodeWriteAuditLogHandler(regionLeader.getDataNodeId()));
}
public void log(IAuditEntity auditLogFields, Supplier<String> log) {}
}
Loading