Hotfix concurrent connect error #16900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
requested changes
Dec 12, 2025
Comment on lines
41
to
61
| private volatile long id; | ||
|
|
||
| private ClientVersion clientVersion; | ||
|
|
||
| private ZoneId zoneId; | ||
|
|
||
| private TimeZone timeZone; | ||
|
|
||
| private long userId; | ||
| private volatile long userId; | ||
|
|
||
| private String username; | ||
| private volatile String username; | ||
|
|
||
| private boolean login = false; | ||
| private volatile boolean login = false; | ||
|
|
||
| private long logInTime; | ||
|
|
||
| private SqlDialect sqlDialect = SqlDialect.TREE; | ||
|
|
||
| @Nullable private String databaseName; | ||
|
|
||
| private long lastActiveTime; | ||
| private volatile long lastActiveTime = CommonDateTimeUtils.currentTime(); |
Contributor
There was a problem hiding this comment.
No need to add these volatile? As discussed last night, ConcurrentHashMap has already made sure that getAllConnections can see the changes made by other threads.
JackieTien97
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.