OAK-11979: Clean up *StringValue in JCR XML import by reschke · Pull Request #2572 · apache/jackrabbit-oak

reschke · 2025-10-10T17:41:00Z

No description provided.

sonarqubecloud · 2025-10-10T19:33:05Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

reschke · 2025-10-10T19:43:04Z

Seems we have mo coverage for Base64 encoded binaries.

rishabhdaim

Can we create unit cases for these files, just to compare the output before & after.

mbaedke · 2025-10-13T11:32:58Z

oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/xml/StringValue.java

-            ByteArrayOutputStream baos = new ByteArrayOutputStream();
            try {
-                Base64.decode(value, baos);
+                byte[] bytes = Base64.getDecoder().decode(value);


Maybe inline that?

reschke · 2025-10-13T12:53:33Z

Before we proceed here, we need test coverage. Optimally separate ticket / PR.

…2509) * OAK-11899 - use default value in case config value can not be parsed * OAK-11899 - if config parameter can not be converted, use default value * OAK-11899 - increase org.apache.jackrabbit.oak.spi.security version

* OAK-11914 : removed usage of Guava's HashBasedTable * OAK-11914 : removed un-necessary usage of computeIfAbsent method

* OAK-11910 : exposed DirectExecutor from ExecutorUtils * OAK-11910 : marked DirectExecutor as public again * OAK-11911 : increased minor version

…alization (#2574)

…rs (#2582)

…or (#2585)

* OAK-11935 : updating aws sdk from 1.x to 2.x * OAK-11935 : added more unit cases * OAK-11935 : added unit cases for S3RequestDecorator * OAK-11935 : fixed issue when running ITs with different encryption mode * OAK-11935 : removed unused imports * OAK-11935 : incorporated review comments * OAK-11935 : added review comments * OAK-11935 : added properties for cross Region access * OAK-11935 : removed additional list for removing keys in case of GCP mode * OAK-11935 : moved out CRUD operations from Utils to S3CrudHelper * OAK-11935 : added unit cases for waitForBucket method * OAK-11935 : make total attemps and delay configurable to use lower values in unit cases * OAK-11935 : remaned S3CrudHelper to S3BackendHelper

…Migrator.migrateBinaryRef is missing a null check (#2586)

* OAK-11984 Support UserId Change for External Users * Removed unused change * Update oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java Co-authored-by: Alejandro Moratinos <Amoratinos@users.noreply.github.com> * Update oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java Co-authored-by: Alejandro Moratinos <Amoratinos@users.noreply.github.com> * moving constants * Added FF * Added tests for FF * Added debug log --------- Co-authored-by: Alejandro Moratinos <Amoratinos@users.noreply.github.com> Co-authored-by: angela <anchela@adobe.com>

* OAK-11936: Allow updating the inference config via JMX * OAK-11936: Apache License added to new classes --------- Co-authored-by: marvinw <marvinw@adobe.com>

* OAK-11949: Sort Union Queries without order-by by score * OAK-11936: restructure if-clause, move import and one additional test * OAK-11949: use double for Null protection --------- Co-authored-by: marvinw <marvinw@adobe.com>

…version

… test case

Fixed.

* OAK-12077 : added joinUninterruptibly() in oak-commons * OAK-12077 : added review comments * OAK-12077 : updated sleep durations to sleep within joining period * OAK-12077 : fixed assertion errors if occured in joiningThread

…mplementation (#2715)

- info log msg should only be logged on debug

done

…ak-commons (#2717)

…ersion bump" This reverts commit 8a13d35.

)" This reverts commit 436f733.

…e in fact only running one thread) (#2679)

…#2699)" This reverts commit 082c3a3.

…OST, FT_OPTIMIZE_IN_RESTRICTIONS_FOR_FUNCTIONS, and FT_NAME_PREFETCH_FOR_QUERIES (#2690)

- restores changes reverted in commit 9bfbce0.

* OAK-12010 Simplified index management (without optimizer) * OAK-12010 Simplified index management * OAK-12010 Simplified index management * OAK-12010 Simplified index management * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndex.java Co-authored-by: Benjamin Habegger <benjamin@habegger.tech> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndex.java Co-authored-by: Benjamin Habegger <benjamin@habegger.tech> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndex.java Co-authored-by: Amit Jain <amitj@apache.org> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexMerger.java Co-authored-by: Amit Jain <amitj@apache.org> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndex.java Co-authored-by: Amit Jain <amitj@apache.org> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/JsonNodeBuilder.java Co-authored-by: Benjamin Habegger <benjamin@habegger.tech> * Update oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndex.java Co-authored-by: Amit Jain <amitj@apache.org> * OAK-12010 Simplified index management * OAK-12010 Simplified index management * OAK-12010 Simplified index management * OAK-12010 Simplified index management * OAK-12010 Simplified index management --------- Co-authored-by: Benjamin Habegger <benjamin@habegger.tech> Co-authored-by: Amit Jain <amitj@apache.org>

…ut issue (#2732)

…ffferedStringValue (#2728)

… for OAK-12039 (#2738) * Revert "OAK-12039 Treat transient client-side exceptions as recoverable in AzureRepositoryLock (#2663)" This reverts commit e4a2b39. * Revert "OAK-12039 test that verifies that lease renewal in AzureRepositoryLockV8 correctly handles client timeout (#2667)" This reverts commit 6697d70.

… changes for OAK-12039 (#2738)" This reverts commit ef8f1d3.

- consistently close FileStores and other closeable objects

Added diagnostic logging.

Replaced the dynamic inline mocking with a static agent dependency.

…#2741)

OAK-11979: Clean up *StringValue in JCR XML import

444b02c

reschke requested review from mbaedke and rishabhdaim October 10, 2025 17:41

reschke self-assigned this Oct 10, 2025

rishabhdaim reviewed Oct 11, 2025

View reviewed changes

mbaedke reviewed Oct 13, 2025

View reviewed changes

mbaedke approved these changes Oct 13, 2025

View reviewed changes

thomasmueller and others added 20 commits February 15, 2026 20:21

OAK-11977 Tree store: BufferOverflowException (#2571)

acb8ef5

OAK-11969 do not check the existence of the tree twice (#2560)

3c063ba

OAK-11934 - segment preloading for PersistentCache (#2569)

58ff6a6

OAK-11914 : removed usage of Guava's HashBasedTable (#2573)

50fb8c1

* OAK-11914 : removed usage of Guava's HashBasedTable * OAK-11914 : removed un-necessary usage of computeIfAbsent method

OAK-11911 : exposed DirectExecutor from ExecutorUtils (#2575)

db6611a

* OAK-11910 : exposed DirectExecutor from ExecutorUtils * OAK-11910 : marked DirectExecutor as public again * OAK-11911 : increased minor version

OAK-11981: blob-plugins - remove use of TransientFileFactory (#2576)

024227b

OAK-11983: benchmarks: remove jackrabbit-core dependency (#2577)

9fdd0c6

OAK-11980 - improve parallelization of I/O during segment-azure initi…

b2891ea

…alization (#2574)

OAK-11985 : added MongoServerUnavailableException into transient erro…

9378356

…rs (#2582)

OAK-11982 move the calculation of the WARN limit out of the construct…

61d5d28

…or (#2585)

OAK-11913 : created Forwarding executir service (#2580)

5327db1

OAK-11987 - org.apache.jackrabbit.oak.segment.azure.tool.SegmentStore…

5b482b5

…Migrator.migrateBinaryRef is missing a null check (#2586)

OAK-11936: Allow updating the inference config via JMX (#2525)

d6ae90d

* OAK-11936: Allow updating the inference config via JMX * OAK-11936: Apache License added to new classes --------- Co-authored-by: marvinw <marvinw@adobe.com>

OAK-11912 : created DirectExecutorServiuce in oak-commons (#2579)

e96909c

OAK-11936: Allow updating the inference config via JMX - fix package …

8a40452

…version

OAK-11936: Allow updating the inference config via JMX - line ends in…

25540a8

… test case

mbaedke and others added 30 commits February 15, 2026 20:22

OAK-10344: oak-run ITs fail with failsafe >= 3.0.0 (#2709)

f44a4ff

Fixed.

OAK-12080 : replaced guava's Comparators.isInOrder with oak-commons i…

d27250b

…mplementation (#2715)

OAK-12069 - reduce SegmentPreloader memory usage (#2718)

23596ba

- info log msg should only be logged on debug

OAK-11941: Upgrade (shaded) Guava to 33.5.0

6d7282e

OAK-10342: Update Apache Parent POM to version 37 (#2716)

b2ce0cc

done

OAK-12083 : replaced guava's Uninterruptible.joinUninterruptibly with o…

e95b57a

…ak-commons (#2717)

OAK-12057 - Select same plan with or without LIMIT option (#2684)

1e002ec

OAK-12057 - Select same plan with or without LIMIT option - version bump

d51ed27

Revert "OAK-12057 - Select same plan with or without LIMIT option - v…

e0911b5

…ersion bump" This reverts commit 8a13d35.

Revert "OAK-12057 - Select same plan with or without LIMIT option (#2684

bba859f

)" This reverts commit 436f733.

OAK-12054: Refactor creation of ThreadPoolExecutors (fix those that w…

1a9db54

…e in fact only running one thread) (#2679)

Revert "OAK-12070 - Reduce memory consumption of azure segment stores (…

64b3962

…#2699)" This reverts commit 082c3a3.

OAK-12063: Remove obsolete feature toggles FT_NAME_IMPROVED_IS_NULL_C…

86e9afe

…OST, FT_OPTIMIZE_IN_RESTRICTIONS_FOR_FUNCTIONS, and FT_NAME_PREFETCH_FOR_QUERIES (#2690)

OAK-12084 - Move GCGeneration class to exported SPI package (#2725)

5d56183

OAK-12070 - Reduce memory consumption of azure segment stores (#2726)

c5da118

- restores changes reverted in commit 9bfbce0.

OAK-12086: oak-segment-tar: remove optional log4j dependency

30a8212

OAK-12087 : bump netty to 4.1.131.Final (#2731)

f26a884

OAK-12088 : added connectionAcquisitionTimeout to avoid acquire timeo…

375dce6

…ut issue (#2732)

OAK-12082: add test coverage for org.apache.jackrabbit.oak.jcr.xml.Bu…

b417928

…ffferedStringValue (#2728)

OAK-12010 (Remove misplaced files)

3b380ec

Revert "OAK-12085: OutOfMemory in oak-segment-azure tests - reverting…

a32bfa6

… changes for OAK-12039 (#2738)" This reverts commit ef8f1d3.

OAK-12085 - OutOfMemory in oak-segment-azure tests (#2739)

efa3082

- consistently close FileStores and other closeable objects

OAK-12066: NPE in AstElement "quote()" (#2708)

b4fd15b

Added diagnostic logging.

OAK-11975: Use Mockito as an agent in Oak (#2653)

cff0385

Replaced the dynamic inline mocking with a static agent dependency.

OAK-12010: Simplified index management - fix JSON comparison in tests (…

674bb78

…#2741)

OAK-12090: Update commons-lang3 dependency to 3.20.0 (#2736)

db43ccd

OAK-12092: Update commons-text dependency to 1.15.0 (#2742)

6db9099

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OAK-11979: Clean up *StringValue in JCR XML import#2572

OAK-11979: Clean up *StringValue in JCR XML import#2572
reschke wants to merge 150 commits intotrunkfrom
OAK-11979

reschke commented Oct 10, 2025

Uh oh!

sonarqubecloud bot commented Oct 10, 2025

Uh oh!

reschke commented Oct 10, 2025

Uh oh!

rishabhdaim left a comment

Uh oh!

mbaedke Oct 13, 2025

Uh oh!

reschke Oct 13, 2025

Uh oh!

reschke commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

reschke commented Oct 10, 2025

Uh oh!

sonarqubecloud bot commented Oct 10, 2025

Quality Gate failed

Uh oh!

reschke commented Oct 10, 2025

Uh oh!

rishabhdaim left a comment

Choose a reason for hiding this comment

Uh oh!

mbaedke Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

reschke Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

reschke commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants