Skip to content

Conversation

@ygjia
Copy link

@ygjia ygjia commented Sep 2, 2025

Why are the changes needed?

Close #7186

How was this patch tested?

Add new UTs and verified in a cluster with ranger hive spark service.

Was this patch authored or co-authored using generative AI tooling?

No

@ygjia
Copy link
Author

ygjia commented Sep 13, 2025

Kindly ping @pan3793 , I’ve added a Ranger policy to cover the RuleFunctionAuthorization tests. Ready for review~

@ygjia ygjia requested a review from pan3793 September 15, 2025 02:22
@ygjia
Copy link
Author

ygjia commented Sep 20, 2025

Kindly ping @pan3793 @bowenliang123 @packyan
Would you mind taking a look when convenient? Thank you!

@ygjia
Copy link
Author

ygjia commented Nov 25, 2025

Kindly ping @pan3793
Would you mind taking a look when convenient? Thank you!

@ygjia ygjia closed this Dec 1, 2025
@ygjia ygjia reopened this Dec 1, 2025
@pan3793
Copy link
Member

pan3793 commented Dec 1, 2025

cc @bowenliang123 and @wForget, do you have time to take a look?

@ygjia ygjia requested a review from wForget December 9, 2025 06:46
@wForget
Copy link
Member

wForget commented Dec 10, 2025

Thanks @ygjia , overall looks good to me. cc @pan3793 @bowenliang123 Do you have any comments?

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (d9e0d36) to head (249c321).
⚠️ Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
...spark/authz/ranger/RuleFunctionAuthorization.scala 0.00% 23 Missing ⚠️
...ubi/plugin/spark/authz/ranger/AccessResource.scala 0.00% 1 Missing ⚠️
...ugin/spark/authz/ranger/RangerSparkExtension.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7187   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         701     697    -4     
  Lines       43565   43553   -12     
  Branches     5911    5886   -25     
======================================
+ Misses      43565   43553   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ygjia
Copy link
Author

ygjia commented Dec 10, 2025

Thanks @pan3793 @wForget @bowenliang123 !
and it seems the CI failure is unrelated—could you please help rerun the failed checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] [Authz] Introduce RuleFunctionAuthorization for persistent function calls authorization

5 participants