-
Notifications
You must be signed in to change notification settings - Fork 971
[KYUUBI #7186] Introduce RuleFunctionAuthorization for persistent function calls authorization #7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...thz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/FunctionPrivilegesBuilderSuite.scala
Outdated
Show resolved
Hide resolved
|
Kindly ping @pan3793 , I’ve added a Ranger policy to cover the RuleFunctionAuthorization tests. Ready for review~ |
|
Kindly ping @pan3793 @bowenliang123 @packyan |
|
Kindly ping @pan3793 |
|
cc @bowenliang123 and @wForget, do you have time to take a look? |
...-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtension.scala
Show resolved
Hide resolved
...z/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleFunctionAuthorization.scala
Show resolved
Hide resolved
|
Thanks @ygjia , overall looks good to me. cc @pan3793 @bowenliang123 Do you have any comments? |
bowenliang123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7187 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 701 697 -4
Lines 43565 43553 -12
Branches 5911 5886 -25
======================================
+ Misses 43565 43553 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...z/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
...z/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
|
Thanks @pan3793 @wForget @bowenliang123 ! |
Why are the changes needed?
Close #7186
How was this patch tested?
Add new UTs and verified in a cluster with ranger hive spark service.
Was this patch authored or co-authored using generative AI tooling?
No