-
Notifications
You must be signed in to change notification settings - Fork 971
[KYUUBI #7226] Support to wait the batch recovery appliction submission to throttle the load on the system #7262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the load on the system
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7262 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 697 +1
Lines 43530 43576 +46
Branches 5883 5891 +8
======================================
- Misses 43530 43576 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f893b04 to
2b0403d
Compare
|
@turboFei So, basically Fei, you updated the recoveryBatches() method so that by sourcing in this newly introduced property kyuubi.session.engine.startup.waitCompletion forces it so that when enabled, the batch recovery task for specific batch job doesn't return and blocks until the associated application actually executes from associated compute engine spin up by kyuubi server? Is this so that the kyuubi server isn't throttled from too many batches being recovered by |
|
Hi @JoonPark1 And the kyuubi server only need to monitor the application states. I think it should be fine. |
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala
Show resolved
Hide resolved
…on to throttle the load on the system ### Why are the changes needed? Support to wait the batch recovery appliction submission to throttle the load on the system. Add a new config to control it Whether a metadata recovery task should wait for its corresponding engine submission to complete before finishing. All recovery tasks are submitted to a fixed thread pool controlled by kyuubi.metadata.recovery.threads. If true, a task blocks until the engine submission is done, helping throttle the load on the system if kyuubi.session.engine.startup.waitCompletion is false. If false, the task returns immediately after opening the session without waiting. Close #7226 ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7262 from turboFei/recover_concurrent. Closes #7226 ea6282d [Wang, Fei] config 2b0403d [Wang, Fei] refine docs b5c5101 [Wang, Fei] refine f6b510c [Wang, Fei] 1.10.3 b892c71 [Wang, Fei] Support to wait the batch recovery appliction submission to throttle the load on the system c4740dc [Wang, Fei] conf Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 572cef8) Signed-off-by: Wang, Fei <[email protected]>
|
thanks, merged to master(1.11.0) and 1.10.3 |
Why are the changes needed?
Support to wait the batch recovery appliction submission to throttle the load on the system.
Add a new config to control it
Whether a metadata recovery task should wait for its corresponding engine submission to complete before finishing. All recovery tasks are submitted to a fixed thread pool controlled by kyuubi.metadata.recovery.threads. If true, a task blocks until the engine submission is done, helping throttle the load on the system if kyuubi.session.engine.startup.waitCompletion is false. If false, the task returns immediately after opening the session without waiting.
Close #7226
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.