Migration to JUnit 5 - avoid using AbstractMojoTestCase #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparsick
requested changes
Jan 12, 2026
Contributor
sparsick
left a comment
sparsick
left a comment
There was a problem hiding this comment.
Also, please check if the following dependencies are still necessary:
<dependency>
<!-- support for JUnit 4 -->
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
Should we rename the test classes, so that they have a Test suffix?
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| public class TestIncludeExcludeUnpackMojo extends AbstractDependencyMojoTestCase { |
Contributor
There was a problem hiding this comment.
Can AbstractDependencyMojoTestCase be deleted? IMHO after this refactoring it should be possible.
Member
Author
There was a problem hiding this comment.
There are still test based on it ...
...java/org/apache/maven/plugins/dependency/fromConfiguration/TestIncludeExcludeUnpackMojo.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public void assertMarkerFiles(Collection<ArtifactItem> items, boolean exist) { | ||
| private void assertMarkerFiles(UnpackMojo mojo, Collection<ArtifactItem> items, boolean exist) { |
Contributor
There was a problem hiding this comment.
Is it the same private method like in TestIncludeExcludeUnpackMojo? If we have more such assert method, we should move them to a separate Assertion class.
Member
Author
There was a problem hiding this comment.
I wil check after finish
- Next part - bump plugin-testing to 3.5.0 - cleanups after parent # Conflicts: # pom.xml
slawekjaranowski
force-pushed
the
junit5-0110
branch
from
e0c8273 to
99e5653
Compare
sparsick
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.