Skip to content

Fix #11885: Disable ANSI colors when stdout is piped on JDK 22+ #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gnodet wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −5
Draft

Fix #11885: Disable ANSI colors when stdout is piped on JDK 22+ #11887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ protected void doCreateTerminal(C context, TerminalBuilder builder) {
context.coloredOutput = context.coloredOutput != null ? context.coloredOutput : false;
context.closeables.add(out::flush);
} else {
builder.systemOutput(TerminalBuilder.SystemOutput.ForcedSysOut);
builder.systemOutput(TerminalBuilder.SystemOutput.SysOut);
}
if (context.coloredOutput != null) {
builder.color(context.coloredOutput);
Expand All @@ -354,12 +354,10 @@ protected void doCreateTerminal(C context, TerminalBuilder builder) {
*/
protected final void doConfigureWithTerminal(C context, Terminal terminal) {
context.terminal = terminal;
// tricky thing: align what JLine3 detected and Maven thinks:
// Align Maven's color setting with JLine's terminal detection:
// if embedded, we default to context.coloredOutput=false unless overridden (see above)
// if not embedded, JLine3 may detect redirection and will create dumb terminal.
// if not embedded, JLine detects redirection via SysOut and will create dumb terminal.
// To align Maven with outcomes, we set here color enabled based on these premises.
// Note: Maven3 suffers from similar thing: if you do `mvn3 foo > log.txt`, the output will
// not be not colored (good), but Maven will print out "Message scheme: color".
MessageUtils.setColorEnabled(
context.coloredOutput != null ? context.coloredOutput : !Terminal.TYPE_DUMB.equals(terminal.getType()));

Expand Down