[core] Abstract LookupSerializerFactory and extract classes from LookupLevels #6659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsreaper
reviewed
Nov 24, 2025
|
|
||
| @Override | ||
| public byte[] persistToDisk(KeyValue kv, long rowPosition) { | ||
| if (persistValue) { |
Contributor
There was a problem hiding this comment.
Both persistToDisk and readFromDisk need to check persistValue. It seems that this class actually combines two PersistProcessor. Split them into two classes.
tsreaper
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor codes for remote sst files. Abstract
LookupSerializerFactoryand extract classes from LookupLevels to clean LookupLevels.Tests
API and Format
Documentation