[core] Overwrite commit should never be conflicted by delete files #6687
+145
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsreaper
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the case of overwrite writing, if a Compact commit is made simultaneously, it may conflict and cause the Overwrite commit to fail.
This should not be because Overwrite itself does not specify the files to be deleted. The files it wants to delete are read from the snapshot, which should be consistent with the commit's base snapshot.
Scan deleted files from snapshot should be aligned to try commit. So in this way, overwrite commit should never be conflicted by delete files.
Tests
API and Format
Documentation