[fix] Handle TLS close_notify to avoid SslClosedEngineException: SSLEngine closed already

[lhotari]

Motivation

Received this log entry which caused unnecessary retries and latency on a Pulsar client:

failed to get Partitioned metadata : SSLEngine closed already org.apache.pulsar.shade.io.netty.handler.ssl.SslClosedEngineException: SSLEngine closed already

There's a similar issue that was resolved in reactor-netty with this PR reactor/reactor-netty#2518

More details:

• https://datatracker.ietf.org/doc/html/rfc8446#section-6.1
• SSL / TLS: Is a server always required to respond to a close notify?
  • Since TLS 1.3, it's not even part of the spec to have a response. In TLS 1.2, it's optional.

Modifications

• Close the channel immediately when TLS close_notify event is received

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[codecov-commenter]

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.32%. Comparing base (2c9fc94) to head (a0673ea).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...g/apache/pulsar/common/protocol/PulsarDecoder.java	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #24986       +/-   ##
=============================================
+ Coverage     38.63%   74.32%   +35.68%     
- Complexity    13324    33664    +20340     
=============================================
  Files          1863     1920       +57     
  Lines        146089   150258     +4169     
  Branches      16942    17431      +489     
=============================================
+ Hits          56445   111672    +55227     
+ Misses        81999    29690    -52309     
- Partials       7645     8896     +1251     

Flag	Coverage Δ
inttests	26.55% <50.00%> (+0.25%)	⬆️
systests	22.83% <0.00%> (+<0.01%)	⬆️
unittests	73.85% <83.33%> (+38.98%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../java/org/apache/pulsar/client/impl/ClientCnx.java	68.97% <ø> (+15.66%)	⬆️
...g/apache/pulsar/common/protocol/PulsarDecoder.java	65.42% <83.33%> (+7.16%)	⬆️

... and 1422 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.