-
Notifications
You must be signed in to change notification settings - Fork 739
feat: Add dark/light theme toggle to documentation website #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implements Material theme palette toggle with three modes: - Automatic mode (follows system preference) - Light mode (default scheme) - Dark mode (slate scheme) Users can now toggle between themes using the icon in the header. All modes preserve the existing deep orange primary and green accent colors. Addresses apache#2444
|
can you show screenshots of both modes? |
|
Wonder why it's showing the old website (before the remodel). The branch is branched off recently, so it should have the commits. Maybe there's an extra step you need to take to apply the fancy formatting? Here's what the current website looks like: https://sedona.apache.org/latest/
|
|
Thanks for reviewing @petern48! I'm not sure why the screenshot is showing the old website design or the duplicate "Apache Sedona" text. My changes only modified the theme.palette section in mkdocs.yml to add the light/dark/auto mode toggle - I didn't touch any template files or other styling. |
|
I agree the behavior is odd. Regardless of your good intentions, we need to make sure this change only does what we want it to do any not modify things unintentionally. To check, you should build the docs on main (ie. without your changes) and compare it to the display of the docs after you apply these changes. Post screenshots here.
This is your screenshot. If it really did render correctly, why don't you attach a screenshot of that? If that's the case, what was the screenshot you sent earlier than? |
|
@petern48 I verified the layout issues you mentioned |





Implements Material theme palette toggle with three modes:
Automatic mode (follows system preference)
Light mode (default scheme)
Dark mode (slate scheme)
Users can now toggle between themes using the icon in the header. All modes preserve the existing deep orange primary and green accent colors.
Closes #2444