stats_over_http: fix incorrect use of C string functions. #12634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of the Accept-Encoding field used strstr() on the result of TSMimeHdrFieldValueStringGet leading to read of uninitialized memory. As a workaround, make a null-terminated copy of the returned string.
cmcfarlen
reviewed
Nov 3, 2025
|
|
||
| // Ensure str is null-terminated for strstr() | ||
| if (len > 0) { | ||
| str = TSstrndup(mime_str, len); |
Contributor
There was a problem hiding this comment.
Instead of this, could you create a std::string_view from {mime_str, Len} and use std::string_view::find to search for the string?
Contributor
Author
There was a problem hiding this comment.
ugghhh I'll think about it. Not very enthusiastic at all about all this code that just duplicates compress, the only reason I'm touching this is to make a thing that insists on sending Accept-Encoding: identity work reliably.
Contributor
There was a problem hiding this comment.
I like the std::string_view suggestion too. It would be nice to avoid the cost of the allocation and the need to free.
Thank you for working on this.
Member
|
[approve ci] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of the
Accept-Encodingfield in thestats_over_httpplugin usedstrstr()on the result ofTSMimeHdrFieldValueStringGetleading to read of uninitialized memory. As a workaround, make a null-terminated copy of the header string.As a matter of opinion, I think the compression support in
stats_over_httpshould be completely removed as it significantly complicates the code for questionable benefit. Ideally users who care about this could stack thecompressplugin, though I'm not clear on whether this works with intercept?