Skip to content

[Relax][PyTorch] Add lower bound support for range constraints #18447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

[Relax][PyTorch] Add lower bound support for range constraints #18447

merged 1 commit into from
Nov 14, 2025
+77 −32

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Nov 14, 2025

Related

Why

  • Previously only extracted upper bounds, discarding lower bound information
  • Enables better memory planning and optimization with full range [min, max]

How

  • Extract both tir_var_lower_bound and tir_var_upper_bound from PyTorch ExportedProgram.range_constraints
  • Update C++ transforms (static_plan_block_memory.cc, adjust_matmul_order.cc) to use lower bounds
  • Default: lower=0 if not specified, upper=INT64_MAX if not specified

@guan404ming guan404ming force-pushed the add-lower-bound-support branch from 3facc8a to fdabccf Compare November 14, 2025 07:05
@guan404ming guan404ming force-pushed the add-lower-bound-support branch from 9b287af to 7c43afc Compare November 14, 2025 07:46
@guan404ming guan404ming marked this pull request as ready for review November 14, 2025 08:55
@guan404ming
Copy link
Member Author

guan404ming commented Nov 14, 2025

cc @mshr-h @tlopex

mshr-h
mshr-h approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@mshr-h mshr-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mshr-h mshr-h merged commit ce0ac66 into apache:main Nov 14, 2025
14 checks passed
@guan404ming
Copy link
Member Author

guan404ming commented Nov 14, 2025

Thanks!

@guan404ming guan404ming deleted the add-lower-bound-support branch November 14, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshr-h mshr-h mshr-h approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guan404ming @mshr-h