fix: remove preinstall script that breaks npm/yarn consumers#894
Open
jmills4122 wants to merge 1 commit intoapify:masterfrom
Open
fix: remove preinstall script that breaks npm/yarn consumers#894jmills4122 wants to merge 1 commit intoapify:masterfrom
jmills4122 wants to merge 1 commit intoapify:masterfrom
Conversation
The `preinstall: "npx only-allow pnpm"` script ships in the published tarball and fires when apify-client is installed as a dependency, blocking npm and yarn users. The `packageManager` field already enforces pnpm for local development via Corepack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
preinstall: "npx only-allow pnpm"script from package.json.This script ships in the published tarball and runs when apify-client is installed as a dependency — it breaks
npm install -g apify-cliand anything else that pulls in apify-client via npm or yarn:The
packageManagerfield already handles pnpm enforcement for local dev via Corepack without affecting downstream consumers.only-allowis also archived and has a known issue with firing during dependency installs.Only affects v2.23.2.