-
Notifications
You must be signed in to change notification settings - Fork 162
docs(docker): add image tag naming convention and version pinning gui… #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docker): add image tag naming convention and version pinning gui… #2185
Conversation
…dance - Added section explaining Docker image tag naming convention (e.g., `22-1.52.0` for Node.js 22 with Playwright 1.52.0) - Added direct links to Docker Hub tags pages for discovering available versions - Added guidance on pinning Playwright/Puppeteer versions for reproducible builds - Clarified that using `*` as version is a legacy approach, with pinning now preferred
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few thoughts and changes requested
Thanks for the fixes! Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Add .claude/rules/writing-style.md with documentation writing guidelines for AI assistants. Based on Apify style guide and TC-MO's technical writer feedback from PR #2185. Includes: - Core principles (simple, factual, technical) - Formatting rules (headings, bold, lists) - Grammar guidelines (articles, Oxford comma) - Terminology standards (Actor capitalization, word choice) - Common mistakes to avoid Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See https://apify.slack.com/archives/CQ96RHG2U/p1768757339018769
22-1.52.0for Node.js 22 with Playwright 1.52.0)*as version is a legacy approach, with pinning now preferredNote
Updates
docker.mdwith guidance to improve reproducibility and clarity around base images.{runtime-version}-{library-version}tags with examplespackage.jsonexamples provided*is legacy and pinning is preferredWritten by Cursor Bugbot for commit 11df06f. Configure here.