Skip to content

Add support for circular dependencies using thunks #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
migueloller wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

Add support for circular dependencies using thunks #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ function disableExperimentalFragmentVariables() {
experimentalFragmentVariables = false;
}

function resolveThunk(maybeFn) {
if (typeof maybeFn === 'function') return maybeFn()
return maybeFn
}

// XXX This should eventually disallow arbitrary string interpolation, like Relay does
function gql(/* arguments */) {
var args = Array.prototype.slice.call(arguments);
Expand All @@ -158,10 +163,13 @@ function gql(/* arguments */) {
var result = (typeof(literals) === "string") ? literals : literals[0];

for (var i = 1; i < args.length; i++) {
if (args[i] && args[i].kind && args[i].kind === 'Document') {
result += args[i].loc.source.body;
// Support thunks for circular dependencies when colocating fragments
var arg = resolveThunk(args[i])

if (arg && arg.kind && arg.kind === 'Document') {
result += arg.loc.source.body;
} else {
result += args[i];
result += arg;
}

result += literals[i];
Expand Down