Open
Conversation
- Updated OpenAPIKit from 3.3.0 to 4.0.0 - Updated Yams minimum version to 5.1.0 as required by OpenAPIKit v4 - Existing code is already compatible with v4 breaking changes: * Already using GenericError instead of InconsistencyError * Already supports OpenAPI v3.0.4 and v3.1.1 version cases * Already using contentTypes (plural) property * AnyCodable usage patterns are compatible Fixes apple#821
Contributor
|
Thank you for the PR, @cnaples79 - it might take me a few days to review and do some extra testing, just FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
from: "3.3.0"tofrom: "4.0.0""4.0.0"..<"7.0.0"tofrom: "5.1.0"Compatibility Analysis
The codebase analysis shows existing code is already compatible with OpenAPIKit v4:
✅ Error Types: Already using
GenericError(not the renamedInconsistencyError)✅ OpenAPI Versions: Already supports v3.0.4 and v3.1.1 version cases
✅ Content Types: Already using
contentTypes(plural) property where applicable✅ AnyCodable: Usage patterns are compatible with v4 requirements
✅ Swift Version: Meets Swift 5.8+ requirement
Test Plan
This addresses the dependency update requested in issue #821, following the migration guide provided by the OpenAPIKit maintainer.
Fixes #821