-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix: correct placeholder text for graphql action editor #41423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReplaced incorrect GraphQL query and variables placeholders in two UI editor components: variables example now shows a single-field JSON object, and the GraphQL body placeholder was changed from a templated/miswrapped snippet to a proper named query with variable declarations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This will also fix #23335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/src/PluginActionEditor/components/PluginActionForm/components/GraphQLEditor/PostBodyData.tsx (1)
33-37: Clarify the widget binding example inEXPECTED_VARIABLEThe single-field JSON example looks good and matches the simplified variables pattern, but
{{ inputName.property }}is a bit abstract. Using a realistic property like.text(which aligns with most Input widget usage) would make the placeholder more immediately actionable for users.For example:
- example: '{\n "name": "{{ inputName.property }}"\n}', + example: '{\n "name": "{{ inputName.text }}"\n}',
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/src/PluginActionEditor/components/PluginActionForm/components/GraphQLEditor/PostBodyData.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (1)
app/client/src/PluginActionEditor/components/PluginActionForm/components/GraphQLEditor/PostBodyData.tsx (1)
49-56: New query placeholder correctly uses a valid GraphQL operationSwitching the placeholder from a templated snippet to a concrete named query with a
$namevariable is a solid fix and should prevent the previous blank/invalid request behavior when users run the default content.
...lient/src/components/formControls/CustomActionControls/CustomGraphQLActionsConfigControl.tsx
Outdated
Show resolved
Hide resolved
...src/PluginActionEditor/components/PluginActionForm/components/GraphQLEditor/PostBodyData.tsx
Show resolved
Hide resolved
tomjose92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR replaces the placeholder text for custom graphql actions with a valid example.
Fixes #41422
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/19724407878
Commit: ac5f41c
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Thu, 27 Nov 2025 04:22:34 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.