fix(ebpf): avoid panic in UpdateKallsyms on missing dependency nodes#5307
Merged
Conversation
UpdateKallsyms iterated policy-selected event IDs and called GetEvent without checking errors, so IDs present in the policy manager but absent from the dependencies tree caused a nil EventNode dereference. Handle GetEvent errors explicitly: treat ErrNodeNotFound as a no-op for ksymbol collection, log unexpected errors at debug, and skip nil nodes defensively.
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential panic in Tracee’s eBPF kernel-symbols update path by making Tracee.UpdateKallsyms() resilient to policy-selected event IDs that are not present in the events dependencies tree.
Changes:
- Handle
t.eventsDependencies.GetEvent(id)errors instead of ignoring them to avoid nil dereferences. - Treat
dependencies.ErrNodeNotFoundas a no-op for ksymbol collection, and log unexpected errors at debug level. - Add a defensive nil check before accessing the returned dependency node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
b734a92 fix(ebpf): avoid panic in UpdateKallsyms on missing dependency nodes
--
2. Explain how to test it
3. Other comments