Add a qsort implementation to Mibench/qsort#11
Open
nickwanninger wants to merge 3 commits intoarcana-lab:masterfrom
Open
Add a qsort implementation to Mibench/qsort#11nickwanninger wants to merge 3 commits intoarcana-lab:masterfrom
nickwanninger wants to merge 3 commits intoarcana-lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of quicksort to the MiBench patches, as calling the libc implementation of quicksort isn't super interesting. I've inlined a version of qsort that DSWP is used, but gets no speedup (the non-expanded input_large.dat takes 3 seconds baseline while the noelle version takes 48 seconds). I am working on an enabler to allow llvm's tailcallelim pass to perform it's work w/o giving up.
The main reason llvm is giving up seems to be that they expect tailcalls to look like this:
where the return is immediately after a recursive call to the function. However, the frontend spits out this code:
and as such, the tailcallelim pass gives up.