Skip to content

Fixes for ESP32 boards #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facchinm merged 5 commits into from
Dec 17, 2025
Merged

Fixes for ESP32 boards #62

facchinm merged 5 commits into from
Dec 17, 2025

Conversation

@facchinm
Copy link
Collaborator

@facchinm facchinm commented Nov 28, 2025

Fixes #61

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Memory usage change @ ff237b5

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 N/A N/A N/A N/A
rp2040:rp2040:rpipico 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash		 % examples/SimpleAccelerometer
RAM for global variables		 % examples/SimpleGyroscope
flash		 % examples/SimpleGyroscope
RAM for global variables		 % examples/SimpleMagnetometer
flash		 % examples/SimpleMagnetometer
RAM for global variables		 %
arduino:mbed_edge:edge_control 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrfox1200 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrvidor4000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
rp2040:rp2040:rpipico 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%,examples/SimpleMagnetometer<br>flash,%,examples/SimpleMagnetometer<br>RAM for global variables,%
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
rp2040:rp2040:rpipico,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Nov 29, 2025
jimbruges
jimbruges reviewed Dec 5, 2025
View reviewed changes
examples/Interrupts_subclassing/Interrupts_subclassing.ino Outdated
myIMU.onInterrupt(print_data);
myIMU.begin();
#if defined(ARDUINO_ARDUINO_NESSO_N1)
myIMU.begin(BOSCH_ACCEL_ONLY);
Copy link

@jimbruges jimbruges Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be BOSCH_ACCELEROMETER_ONLY?

Copy link
Collaborator Author

@facchinm facchinm Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitly yes, thanks for spotting 😓 Copy pasting from a sketch into a PR is never a good idea 🙂

Copy link

@jimbruges jimbruges Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the one below should be BOSCH_ACCEL_AND_MAGN too rather than BOSCH_ACCEL_AND_GYRO

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Memory usage change @ 7d4f75d

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:samd:mkr1000 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 💚 -12 - -12 -0.0 - -0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 N/A N/A N/A N/A
rp2040:rp2040:rpipico 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash		 % examples/SimpleAccelerometer
RAM for global variables		 % examples/SimpleGyroscope
flash		 % examples/SimpleGyroscope
RAM for global variables		 % examples/SimpleMagnetometer
flash		 % examples/SimpleMagnetometer
RAM for global variables		 %
arduino:mbed_edge:edge_control 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkr1000 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrfox1200 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrgsm1400 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrnb1500 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrvidor4000 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrwan1300 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrwan1310 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrwifi1010 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
arduino:samd:mkrzero -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0
esp32:esp32:esp32 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
rp2040:rp2040:rpipico 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
Click for full report CSV 
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%,examples/SimpleMagnetometer<br>flash,%,examples/SimpleMagnetometer<br>RAM for global variables,%
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrfox1200,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrgsm1400,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrnb1500,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrvidor4000,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrwan1300,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrwan1310,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrwifi1010,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
arduino:samd:mkrzero,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0
esp32:esp32:esp32,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
rp2040:rp2040:rpipico,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0

@facchinm facchinm requested a review from ubidefeo December 17, 2025 16:20
ubidefeo
ubidefeo approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@facchinm facchinm merged commit fd7295f into master Dec 17, 2025
37 checks passed
@facchinm facchinm mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

+1 more reviewer

@jimbruges jimbruges jimbruges left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Library fails to compile for ESP32-based boards due to type mismatch in min()

5 participants

@facchinm @ubidefeo @jimbruges @per1234