-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(sso): allow custom ca configuration #14989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bradfordwagner <[email protected]>
f656884 to
5c376f0
Compare
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Testing EvidenceinsecureSkipVerify=true, rootCA=‘’, rootCAFile=‘’, cacerts_mount=unmountedinsecureSkipVerify=false, rootCA=‘’, rootCAFile=‘’, cacerts_mount=unmounted
insecureSkipVerify=false, rootCA=‘’, rootCAFile=‘/cacerts/ca.crt’, cacerts_mount=/cacertsinsecureSkipVerify=false, rootCA=‘’, rootCAFile=‘’, cacerts_mount=/etc/ssl/certsinsecureSkipVerify=false, rootCA=’MIIGFTCCA/2gAwIBAgIUKNdK/1S4x7Rm2WKDDYfGZYI76igwDQYJKoZIhvcNAQEL’, rootCAFile=‘’, cacerts_mount=unmounted |
|
@MasonM - I felt more comfortable signing off on changes I could test (adding custom ca certificate support to the idp connection) so I decided to raise a separate PR. Connections which require mTLS to IDP should be a simple enough PR from these changes. I also allowed for default cacertificate ie /etc/ssl/certs to be loaded which would not require setting either rootCA, or rootCAFile. |
Signed-off-by: Mason Malone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bradfordwagner! I think we should update the local development environment to support testing this, because we (the maintainers) need to be able to reproduce bug reports involving this feature. I created a quick POC for that here off this branch: MasonM@0633548
Use this link to create a CodeSpace from this commit: https://github.com/codespaces/new?hide_repo_select=true&ref=add-dev-environment&repo=856626547&skip_quickstart=true&machine=standardLinux32gb&devcontainer_path=.devcontainer%2Fdevcontainer.json&geo=UsWest
I did some brief testing and it appears to work using make start UI_SECURE=true PROFILE=sso. I'm not happy about the hacky sed command, but I can't think of a better approach. If that does work for you too, then it just needs to be documented in docs/running-locally.md, as was done for #14894
Signed-off-by: bradfordwagner <[email protected]>
b9cb850 to
15bb35f
Compare
…e/sso-cacerts Signed-off-by: bradfordwagner <[email protected]>
3bef6fa to
c247076
Compare
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
Signed-off-by: bradfordwagner <[email protected]>
MasonM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just a few minor comments
Co-authored-by: Mason Malone <[email protected]> Signed-off-by: Bradford Wagner <[email protected]>
Co-authored-by: Mason Malone <[email protected]> Signed-off-by: Bradford Wagner <[email protected]>
…p.yaml Co-authored-by: Mason Malone <[email protected]> Signed-off-by: Bradford Wagner <[email protected]>
MasonM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I appreciate your persistence
Fixes #7198
Motivation
Enable sso connections to identity provider to use a custom cacert to enable chain of trust verification.
Modifications
Documentation
Verification
make start UI_SECURE=true PROFILE=sso