Skip to content

fix!: return latest workflow for retried-persisted workflows #15030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

fix!: return latest workflow for retried-persisted workflows #15030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion persist/sqldb/workflow_archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ func phaseEqual(phase string) db.Cond {
}

func (r *workflowArchive) GetWorkflow(ctx context.Context, uid string, namespace string, name string) (*wfv1.Workflow, error) {
logger := logging.RequireLoggerFromContext(ctx)
var err error
archivedWf := &archivedWorkflowRecord{}
if uid != "" {
Expand All @@ -533,14 +534,19 @@ func (r *workflowArchive) GetWorkflow(ctx context.Context, uid string, namespace
}
num := int64(total.Total)
if num > 1 {
return nil, fmt.Errorf("found %d archived workflows with namespace/name: %s/%s", num, namespace, name)
logger.WithFields(logging.Fields{
"namespace": namespace,
"name": name,
"num": num,
}).Debug(ctx, "returning latest of archived workflows")
}
err = r.session.SQL().
Select("workflow").
From(archiveTableName).
Where(r.clusterManagedNamespaceAndInstanceID()).
And(namespaceEqual(namespace)).
And(nameEqual(name)).
OrderBy("-startedat").
One(archivedWf)
} else {
return nil, sutils.ToStatusError(fmt.Errorf("both name and namespace are required if uid is not specified"), codes.InvalidArgument)
Expand Down
Loading