fix(github): remove PR options conversion, pass ListOptions directly to avoid nil panic #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutar
force-pushed
the
github-comment-panic
branch
2 times, most recently
from
b519a79 to
e5dce1f
Compare
…to avoid nil panic Signed-off-by: John Soutar <[email protected]>
soutar
force-pushed
the
github-comment-panic
branch
from
e5dce1f to
57b44d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a nil pointer panic when creating/updating GitHub PR comments (see #405). The crash came from the PR adapter converting
PullRequestListOptions→ListOptionsand dereferencing a nil options value.Rather than band-aid with a nil check, I removed the conversion entirely and now pass
*github.ListOptionsstraight through to go-github. That endpoint only supports pagination anyway, so acceptingPullRequestListOptionsimplied filters (state/head/base) that were never used.Net result: no behavioural change for callers (passing nil is fine; go-github tolerates it), clearer API (pagination only), and no more nil-deref in the adapter.