Skip to content

fix(repo): use tsx fallback on Node 26+ for NODE_OPTIONS #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabroberge wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −7
Open

fix(repo): use tsx fallback on Node 26+ for NODE_OPTIONS #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions ark/repo/nodeOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,33 @@
// @ts-check

/** @param {number} major @returns {string} */
function getFallbackReason(major) {
if (major >= 26) {
return "Node.js >= 26 does not allow --experimental-transform-types in NODE_OPTIONS; falling back to tsx..."
}

return "--experimental-transform-types requires Node >= 22.7.0, falling back to tsx..."
}

/**
* @param {number} major
* @param {number} minor
* @returns {string}
*/
function versionedFlagsFor(major, minor) {
const useExperimentalTransformTypes =
(major > 22 && major < 26) || (major === 22 && minor >= 7)
if (useExperimentalTransformTypes) {
return "--experimental-transform-types --no-warnings"
}

console.log(getFallbackReason(major))
return "--import tsx"
}

const [major, minor] = process.version.replace("v", "").split(".").map(Number)

const versionedFlags =
major > 22 || (major === 22 && minor >= 7) ?
"--experimental-transform-types --no-warnings"
: (console.log(
"--experimental-transform-types requires Node >= 22.7.0, falling back to tsx..."
),
"--import tsx")
const versionedFlags = versionedFlagsFor(major, minor)

export const nodeDevOptions = `${process.env.NODE_OPTIONS ?? ""} --conditions ark-ts ${versionedFlags}`

Expand Down
Loading