Skip to content

Conversation

@dzbarsky
Copy link
Collaborator

We shouldn't pull in both bazel-libs.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@dzbarsky dzbarsky requested a review from arrdem December 16, 2025 13:52
@aspect-workflows
Copy link

aspect-workflows bot commented Dec 16, 2025

test-os:linux-bzl:8 (Test)

⚠️ Buildkite build #1682 failed.


test-os:linux-bzl:latest (Test)

26 test targets passed

Targets
//examples/multi_version:py_version_default_test [k8-fastbuild]                           1s
//examples/multi_version:py_version_test [k8-fastbuild]                                   1s
//examples/pytest:absolute_main_test [k8-fastbuild]                                       434ms
//examples/pytest:main_with_colon_test [k8-fastbuild]                                     668ms
//examples/pytest:pytest_test [k8-fastbuild]                                              2s
//examples/pytest:sharded/test [k8-fastbuild]                                             3s
//examples/virtual_deps:pytest_test [k8-fastbuild]                                        2s
//py/private/py_venv:test_link [k8-fastbuild]                                             298ms
//py/tests/external-deps:test_can_import_runfiles_helper [k8-fastbuild]                   902ms
//py/tests/internal-deps:assert [k8-fastbuild]                                            567ms
//py/tests/py-binary:runfiles_from_pip_test [k8-fastbuild]                                774ms
//py/tests/py-binary:test__main_from_name [k8-fastbuild]                                  120ms
//py/tests/py-binary:test__run_py_test_help [k8-fastbuild]                                96ms
//py/tests/py-internal-venv:test [k8-fastbuild]                                           190ms
//py/tests/py-pex-binary:test__print_modules_pex [k8-fastbuild]                           98ms
//py/tests/py-test:test_env_vars [k8-fastbuild]                                           482ms
//py/tests/py-venv-disable-systemsite:test [k8-fastbuild]                                 187ms
//py/tests/py-venv-disable-usersite:test [k8-fastbuild]                                   162ms
//py/tests/py-venv-enable-site:test [k8-fastbuild]                                        211ms
//py/tests/py-venv-standalone-interpreter:test [k8-fastbuild]                             137ms
//py/tests/py_image_layer:py_image_test [k8-fastbuild]                                    5s
//py/tests/py_venv_conflict:validate_import_roots [k8-fastbuild]                          311ms
//py/tests/py_venv_image_layer:py_amd64_image_command_test [k8-fastbuild]                 2s
//py/tests/py_venv_image_layer:py_amd64_image_content_test [k8-fastbuild]                 305ms
//py/tests/py_venv_image_layer:py_arm64_image_content_test [k8-fastbuild]                 3s
//py/tests/repo_relative_imports/test:test [k8-fastbuild]                                 525ms

Total test execution time was 26s. 12 tests (31.6%) were fully cached saving 24s.


test-os:linux-bzl:8 (Test)

e2e

11 test targets passed

Targets
//cases/cross-repo-610:test [k8-fastbuild]                                                171ms
//cases/interpreter-version-541:test_3_10_classic [k8-fastbuild-ST-0d3860f234bd]          531ms
//cases/interpreter-version-541:test_3_10_venv [k8-fastbuild-ST-0d3860f234bd]             207ms
//cases/interpreter-version-541:test_3_11_classic [k8-fastbuild]                          343ms
//cases/interpreter-version-541:test_3_11_venv [k8-fastbuild]                             161ms
//cases/interpreter-version-541:test_3_9_classic [k8-fastbuild-ST-1311592336af]           364ms
//cases/interpreter-version-541:test_3_9_venv [k8-fastbuild-ST-1311592336af]              182ms
//cases/repository-rule-deps-299:all_direct [k8-fastbuild]                                533ms
//cases/repository-rule-deps-299:test [k8-fastbuild]                                      423ms
//cases/uv-deps-650/airflow:airflow [k8-fastbuild-ST-ba1312b31f78]                        352ms
//cases/uv-deps-650/say:say [k8-fastbuild-ST-934aa07688c9]                                554ms

Total test execution time was 4s. 3 tests (21.4%) were fully cached saving 4s.


test-os:linux-bzl:latest (Test)

e2e

11 test targets passed

Targets
//cases/cross-repo-610:test [k8-fastbuild]                                                128ms
//cases/interpreter-version-541:test_3_10_classic [k8-fastbuild-ST-0d3860f234bd]          946ms
//cases/interpreter-version-541:test_3_10_venv [k8-fastbuild-ST-0d3860f234bd]             160ms
//cases/interpreter-version-541:test_3_11_classic [k8-fastbuild]                          413ms
//cases/interpreter-version-541:test_3_11_venv [k8-fastbuild]                             129ms
//cases/interpreter-version-541:test_3_9_classic [k8-fastbuild-ST-1311592336af]           596ms
//cases/interpreter-version-541:test_3_9_venv [k8-fastbuild-ST-1311592336af]              157ms
//cases/repository-rule-deps-299:all_direct [k8-fastbuild]                                337ms
//cases/repository-rule-deps-299:test [k8-fastbuild]                                      531ms
//cases/uv-deps-650/airflow:airflow [k8-fastbuild-ST-ba1312b31f78]                        328ms
//cases/uv-deps-650/say:say [k8-fastbuild-ST-934aa07688c9]                                253ms

Total test execution time was 4s. 3 tests (21.4%) were fully cached saving 4s.


test-os:linux-bzl:8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.


test-os:linux-bzl:latest (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.

@arrdem arrdem self-assigned this Dec 16, 2025
@arrdem arrdem added this to the 2.0.0 milestone Dec 16, 2025
@arrdem
Copy link
Collaborator

arrdem commented Dec 16, 2025

Yep, this and ripping out the WORKSPACE file is the basis of the 2.0 I want to cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants