-
-
Notifications
You must be signed in to change notification settings - Fork 80
feat: support bazel path-mapping #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
dzbarsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you check that to_output_relative_path works as we expect?
| ) + ( | ||
| [ctx.executable.protoc_gen_connect_query] if ctx.attr.gen_connect_query else [] | ||
| ), | ||
| env = {"BAZEL_BINDIR": ctx.bin_dir.path}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm can you check with -s what gets sent here? I'm not convinced this .path won't break it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be an issue basically anywhere a js_binary is run?
SUBCOMMAND: # //ts/test:use_tsconfig_file [action 'TsValidateOptions ts/test/use_tsconfig_file_params.validation', configuration: acb2e42730a6aa54083f4bef3b595e5f72ad2d5bca2cad0bf6ae4c508646ead4, execution platform: @@platforms//host:host, mnemonic: TsValidateOptions]
(cd /private/var/tmp/_bazel_jason/e367b9c6c43239d8dcd71785defc8675/execroot/_main && \
exec env - \
BAZEL_BINDIR=bazel-out/darwin_arm64-fastbuild/bin \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/_main~ext~npm_typescript/validator_/validator ts/test/src_tsconfig2.json ts/test/use_tsconfig_file_params.validation @@//ts/test:use_tsconfig_file ts/test '{"allow_js":false,"composite":false,"declaration":true,"declaration_map":false,"emit_declaration_only":false,"incremental":false,"isolated_typecheck":false,"no_emit":false,"out_dir":"outdir2","preserve_jsx":false,"resolve_json_module":false,"root_dir":"","source_map":false,"ts_build_info_file":""}')
# Configuration: acb2e42730a6aa54083f4bef3b595e5f72ad2d5bca2cad0bf6ae4c508646ead4
# Execution platform: @@platforms//host:host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean this PR has essentially no effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i believe so
It only uses |
32a9fc8 to
0c1f8eb
Compare
0c1f8eb to
b0838bc
Compare
|
Blocked on aspect-build/rules_js#2581 |



Ref aspect-build/rules_js#2574
Changes are visible to end-users: yes
Support bazel path mapping across compilation modes etc.
Test plan