Skip to content

tests/channels/pjsip/sdp_mandatory_lines: Added test to check the validity of SDP s= and o= lines#125

Merged
github-actions[bot] merged 1 commit intoasterisk:masterfrom
AlexisHadj:testRFC8866
Mar 3, 2026
Merged

tests/channels/pjsip/sdp_mandatory_lines: Added test to check the validity of SDP s= and o= lines#125
github-actions[bot] merged 1 commit intoasterisk:masterfrom
AlexisHadj:testRFC8866

Conversation

@AlexisHadj
Copy link
Contributor

This new test verifies that the SDP Session Name (s=) and
Origin (o=) lines are present and contain valid data, as required by RFC 8866.

1-Added SIPp scenario to initiate a call with
validation on the SDP session (s=) and origin (o) lines.
2-Added Asterisk configuration (pjsip.conf, extensions.conf) to
support the test.
3-Registered the new test in the pjsip test suite.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions
Copy link

Workflow PRCheck failed
master-gates: FAILED TEST: channels/pjsip/message/message_out_dialog

@github-actions
Copy link

Workflow PRCheck completed successfully

@AlexisHadj
Copy link
Contributor Author

AlexisHadj commented Feb 17, 2026

cherry-pick-to: 20
cherry-pick-to: 22
cherry-pick-to: 23

@github-actions
Copy link

Workflow PRCheck completed successfully

…idity of SDP s= and o= lines

This new test verifies that the SDP Session Name (s=) and
Origin (o=) lines are present and contain valid data, as required by RFC 8866.

1-Added SIPp scenario to initiate a call with
  validation on the SDP session (s=) and origin (o) lines.
2-Added Asterisk configuration (pjsip.conf, extensions.conf) to
  support the test.
3-Registered the new test in the pjsip test suite.
@AlexisHadj
Copy link
Contributor Author

Looking at the failing task above it seems to me that this statement: asterisk-test-pr: 1754 is causing the grief. 1754 is the associated PR that this test scenario is meant to be testing. Any insight is appreciated

@gtjoseph
Copy link
Member

Looking at the failing task above it seems to me that this statement: asterisk-test-pr: 1754 is causing the grief. 1754 is the associated PR that this test scenario is meant to be testing. Any insight is appreciated

Don't worry about it. It was an issue with a workflow issue I made yesterday morning.

@github-actions
Copy link

Workflow PRCheck completed successfully

@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Workflow PR failed
20-build: cherryPick.sh: Unable to cherry-pick commit 'pjsip_configuration: Ensure s= and o= lines in SDP are never empty' to branch 20
22-build: cherryPick.sh: Unable to cherry-pick commit 'pjsip_configuration: Ensure s= and o= lines in SDP are never empty' to branch 22
23-build: cherryPick.sh: Unable to cherry-pick commit 'pjsip_configuration: Ensure s= and o= lines in SDP are never empty' to branch 23

@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-test cherry-pick-checks-failed Cherry-Pick checks failed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Workflow PR completed successfully

@github-actions github-actions bot merged commit b109662 into asterisk:master Mar 3, 2026
57 of 62 checks passed
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Successfully merged to branch master and cherry-picked to ["20","22","23"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants