Completed auth functionality #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astro
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the tests provided by @anton-smagin the auth functionality is finally implemented. I've bumped the gem version to 1.8.0 so a new release can incorporate this - @astro would you pls push to rubygems?
net-http-socksproxy-with-authbranch can be deleted now.Only change made here (on
master) was to use keyword args instead of positional args for username and password, as long params lists are bad form in Ruby. I've added a README example for auth too. I may seek to rationalize the test deps in future. Thanks again to all who contributed to and chased up this long overdue addition.