Add in pixel to rem, fix some minor requirements issues#20
Open
iamcarrico wants to merge 1 commit intoat-import:masterfrom
Open
Add in pixel to rem, fix some minor requirements issues#20iamcarrico wants to merge 1 commit intoat-import:masterfrom
iamcarrico wants to merge 1 commit intoat-import:masterfrom
Conversation
Member
|
Looks OK, but I need docs before I can merge it in |
Member
|
Please reroll this against current head and only include the pixel to rem changes. Additionally, there are line notes that should be addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few issues with the requires for testing, fixed those as well as added in a mixin to do pixel-to-rem, that will print out something like this: