Skip to content

Conversation

@UdaySagar-Git
Copy link
Member

@UdaySagar-Git UdaySagar-Git commented Jan 13, 2026

✨ Description

adds support for new data quality rule templates

Linear links:

docs pr: https://github.com/atlanhq/atlan-developer-portal/pull/507


🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

Describe how the change was tested. Include:

  • Steps to reproduce
  • Any relevant screenshots, logs, or links to successful workflow runs
  • Details on environment/setup if applicable

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

Note

Introduces typed DQ rule templates and expands rule creation/validation, plus cache and test updates.

  • Switches rule APIs to DataQualityRuleTemplateType (vs strings) and reads template config via rule_type.value
  • Adds support for reconciliation and reference conditions via DQRuleConditionsBuilder (IN_LIST_REFERENCE, ROW_COUNT_RECON, AVERAGE_RECON, SUM_RECON, DUPLICATE_COUNT_RECON, UNIQUE_COUNT_RECON); validates required fields and serializes to JSON
  • Implements row-scope filtering support: _fetch_assets_for_row_scope_validation and _validate_template_features (checks template capabilities, allowed operators/conditions, presence of row-scope filter columns on base/target assets)
  • Enhances creators/updater: optional threshold_compare_operator with template-driven defaults/validation, optional threshold_unit (default from template), rule_conditions, and custom_sql_return_type
  • Adds enums DataQualityRuleTemplateType, extends DataQualityRuleTemplateConfigRuleConditions, and adds ABSOLUTE to DataQualityRuleThresholdUnit
  • Updates DQ template config cache to key by template name (not display name); docstrings adjusted
  • Tests updated to cover new enums, validation paths, row-scope helpers, reconciliation conditions, and custom SQL return type

Written by Cursor Bugbot for commit 44381eb. This will update automatically on new commits. Configure here.

@UdaySagar-Git UdaySagar-Git changed the title DQ-421 feat: add support for new data quality rule templates DQ-421 | feat: add support for new data quality rule templates Jan 13, 2026
@UdaySagar-Git UdaySagar-Git marked this pull request as ready for review January 13, 2026 18:02
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @UdaySagar-Git let's make sure we manually test these changes on tenant? 🙏

@Aryamanz29 Aryamanz29 added the feature New feature or request label Jan 14, 2026
@Aryamanz29 Aryamanz29 merged commit fed0f11 into main Jan 14, 2026
57 of 71 checks passed
@Aryamanz29 Aryamanz29 deleted the DQ-421 branch January 14, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants