This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Don't save to existing location if not modified#94
Open
jamesgpearce wants to merge 1 commit intoatom:masterfrom
jamesgpearce:no-save-unless-is-modified
Open
Don't save to existing location if not modified#94jamesgpearce wants to merge 1 commit intoatom:masterfrom jamesgpearce:no-save-unless-is-modified
jamesgpearce wants to merge 1 commit intoatom:masterfrom
jamesgpearce:no-save-unless-is-modified
Conversation
Holding down cmd-S too long will cause multiple synchronous saves which can be expensive if there is heavyweight linter activity listening for the save events. This simply debounces it (in a sense) by not saving it the file if it is known not to have changed. Also this has no effect on saving new files for the first time.
Author
|
bounced travis and all is good... please review! |
Contributor
|
Please add specs to this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding down cmd-S too long will cause multiple synchronous saves which can be expensive if there is heavyweight linter activity listening for the save events.
This simply debounces it (in a sense) by not saving it the file if it is known not to have changed. Also this has no effect on saving new files for the first time.