-
-
Notifications
You must be signed in to change notification settings - Fork 444
ISSUE-724 # Increase JVM heap size for tests and use rawBody for large/binary responses to prevent OutOfMemoryError in Zerocode scenarios #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,24 +1,22 @@ | ||||||||||
| { | ||||||||||
| "scenarioName": "Validate the GET api", | ||||||||||
| "steps": [ | ||||||||||
| { | ||||||||||
| "name": "get_user_details", | ||||||||||
| "url": "/users/octocat", | ||||||||||
| "method": "GET", | ||||||||||
| "request": { | ||||||||||
| "headers" : { | ||||||||||
| "Content-Type" : "application/json" | ||||||||||
| } | ||||||||||
| }, | ||||||||||
| "verify": { | ||||||||||
| "status": 200, | ||||||||||
| "headers" : { | ||||||||||
| "Content-Type" : [ "application/json; charset=utf-8" ] | ||||||||||
| }, | ||||||||||
| "body": { | ||||||||||
| "login" : "octocat" | ||||||||||
| } | ||||||||||
| } | ||||||||||
| "scenarioName": "Validate the GET api", | ||||||||||
| "steps": [ | ||||||||||
| { | ||||||||||
| "name": "get_user_details", | ||||||||||
| "url": "/users/octocat", | ||||||||||
| "method": "GET", | ||||||||||
| "request": { | ||||||||||
| "headers": { | ||||||||||
| "Content-Type": "application/json" | ||||||||||
| } | ||||||||||
| ] | ||||||||||
| } | ||||||||||
| }, | ||||||||||
| "verify": { | ||||||||||
| "status": 200, | ||||||||||
| "headers": { | ||||||||||
| "Content-Type": ["application/json; charset=utf-8"] | ||||||||||
| }, | ||||||||||
| "rawBody": "{\"login\":\"octocat\"}" | ||||||||||
|
||||||||||
| "rawBody": "{\"login\":\"octocat\"}" | |
| "body": { | |
| "login": "octocat" | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded argLine configuration in pluginManagement will conflict with the JDK 17+ profile at lines 462-485. The JDK 17+ profile sets its own argLine with
--add-opensflags required for Java 17+. When both are present, only one argLine will take effect (typically the profile's configuration overrides pluginManagement).This means that either:
The recommended solution is to use the @{argLine} placeholder pattern to allow both configurations to be combined. In pluginManagement, use
<argLine>-Xmx2048m</argLine>, and in the JDK 17+ profile, use<argLine>@{argLine} --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED</argLine>. Alternatively, add the memory configuration to the JDK 17+ profile as well.