ISSUE-268 # Support timezone-aware datetime assertions#771
Open
officialasishkumar wants to merge 1 commit into
Open
ISSUE-268 # Support timezone-aware datetime assertions#771officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Owner
|
CI is running here now, once Green, we'll have a review soon. Also, can you add couple of integration tests as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support timezone-aware datetime assertions
Fixed Which Issue?
PR Branch
https://github.com/officialasishkumar/zerocode/tree/issue-268-date-timezone
Motivation and Context
$LOCAL.DATETIME.AFTERand$LOCAL.DATETIME.BEFOREparsed ISO datetimes intoLocalDateTime, which ignored offset semantics for values such asZor+02:00. That meant comparisons used the wall-clock value instead of comparing equivalent instants.This change adds a shared datetime parser for assertion expected values and actual response values. It preserves plain ISO local datetime support, honors ISO offsets and
Z, and adds RFC-1123 HTTP-date parsing for values such asLast-Modified.Validation run locally:
mvn -pl core -Dtest=ZeroCodeAssertionsProcessorImplTest test -ntpChecklist:
1. New Unit tests were added
2. Integration tests were added
3. Test names are meaningful
3.1 Feature manually tested and outcome is successful
4. PR doesn't break any of the earlier features for end users
5. PR doesn't break the HTML report features directly
/targetfolder and they look fine6. PR doesn't break any HTML report features indirectly
7. Branch build passed in CI
8. No 'package.*' in the imports
9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user
10. Http test added to
http-testing-examplesmodule(if applicable) ?11. Kafka test added to
kafka-testing-examplesmodule(if applicable) ?