Open
Conversation
It looks a lot better with the current content.
dave-shawley
force-pushed
the
log-format
branch
2 times, most recently
from
e14c267 to
6abc3a4
Compare
dave-shawley
force-pushed
the
log-format
branch
from
6abc3a4 to
2fe10fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 71 116 +45
Branches 11 19 +8
=========================================
+ Hits 71 116 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new module that will build
logging.config.dictConfigready dictionaries for services and command-line applications.jsonscribe.get_service_configurationreturns a dictionary that is wired to use JSON-based logging andjsonscribe.get_cli_configurationreturns a similar dictionary that produces human-readable logs.Both functions respond to the
DEBUGandLOG_FORMATenvironment variables. IfDEBUGis set and determined to be truthy, then the root log level is set to debug instead of info (the default). TheLOG_FORMATenvironment variable can be set to eitherjsonorplainto explicitly select a format regardless of what the application has configured. The functions both support parameters that can be used to influence the decision as well though the options probably won't see much use.