Skip to content

refactor: improve build scripts #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: improve build scripts #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f25622
refactor: improve build scripts
Feb 14, 2023
c0a82e9
fix: call python templates variable
Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
This repository consists of different Component Templates supported by Greengrass Development Kit - CLI.

### Build instructions
After you have made changes to templates or have added new changes, make sure your template name is listed in corresponding `build.sh` and it can be built using the same.

To ensure that, new changes doesnt cause any regression, execute parent `build.sh` included in `aws-greengrass-component-templates`
## Security

Expand Down
2 changes: 1 addition & 1 deletion templates/java/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

maven_templates='HelloWorld'
maven_templates=$(ls -d */ | sed 's/\//\n/g')
Copy link
Member

@saranyailla saranyailla Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This change assumes that all the templates inside Java can be built with maven. This will have to be modified if things change and that is also fine.

Copy link
Contributor Author

@Nelsonochoam Nelsonochoam Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the current one is assuming the same. This is just improving it so we don't have to add the names of the folders every time we add a new template

Copy link
Member

@saranyailla saranyailla Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, wondering is we should build these with gdk commands as that's we expect.

Copy link
Contributor Author

@Nelsonochoam Nelsonochoam Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm definitely gdk commands I think.

Copy link
Contributor Author

@Nelsonochoam Nelsonochoam Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will hold off on trying to do this. Right now the gdk does not allow you to specify the path to the artifact and for the OTF framework it is inside one of the submodules

current_directory=`pwd`
for template in $maven_templates; do
cd $current_directory/$template
Expand Down
9 changes: 8 additions & 1 deletion templates/python/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
#!/bin/bash
#!/bin/bash

python_templates=$(ls -d */ | sed 's/\//\n/g')
current_directory=`pwd`
for template in $python_templates; do
cd $current_directory/$template
echo "Building $template template"
done