Extract example for static sites from single page applications example #21
Open
thomasturrell wants to merge 2 commits intoaws-samples:mainfrom
Open
Extract example for static sites from single page applications example #21thomasturrell wants to merge 2 commits intoaws-samples:mainfrom
thomasturrell wants to merge 2 commits intoaws-samples:mainfrom
Conversation
thomasturrell
force-pushed
the
main
branch
3 times, most recently
from
5056adc to
ab841be
Compare
Contributor
Author
|
I believe that the duplication in the test is a pragmatic solution because there are links to the existing files. Ideally the structure would be changes so that there was only one set of tests. @dbrown-git I would appreciate your thoughts. I am happy to further explain my rational for this pull request if it is not clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: Static sites and single page web applications typically have different requirements. Static sites tend to have have an index.html file for each folder where as single page applications only have a single index.html in the root. Single page application typically use a client router to handle the routes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.