-
Notifications
You must be signed in to change notification settings - Fork 551
feat: add fsxl_module w/rchandra20 to fundamentals #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed source file.
…-fsxl.pdn Removed source file.
❌ Deploy Preview for eks-workshop failed.
|
ROunofF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
hi just checking in on this, let me know if you need any mods or help getting it approved and merged |
terraform linting
Head branch was pushed to by a user without write access
added test duration for fsxl index page and set to 0
|
added a test duration for fsxl module and set the duration to zero, we can run the workflow again |
Updated resource path from base-application/assets to base-application/ui
|
summary: todo: |
What this PR does / why we need it:
This PR adds the FSxL fundamentals module, including source code and website markdown.
Which issue(s) this PR fixes:
Fixes #823
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.