-
Notifications
You must be signed in to change notification settings - Fork 96
fix: make containerd config check compatible with new config version #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wwvela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
CI failing due to no space left on runner device. Will retry in a while. Should not be related to our changes |
|
the neuron build CI should pass if rebased on main btw #719 |
mselim00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
an aside, this could be better as a python script or if there were some hypothetical command-line tq that handles toml serialization
|
flaky build ci due to space running out. Trying it once agian |
Issue #, if available:
The containerd config check test fails since it assumes that we will always find pause image by the name
sandbox_imagebut in newer config versions this does not hold true.sandbox_image = "registry.k8s.io/pause:3.10.1"sandbox = 'registry.k8s.io/pause:3.10.1'For more details: https://github.com/containerd/containerd/blob/main/docs/cri/config.md
Description of changes:
Attempt to extract 'sandbox' from the config to be compatible with latest containerd config.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.