Fix proxy basic auth #6584
Merged
Fix proxy basic auth #6584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Apache5, the auth scheme requires a specific class type for the Credentials object, otherwise the credentials will be considered missing. NTLMScheme: https://github.com/apache/httpcomponents-client/blob/79992d832cc5d9fb4ce8307200dae844085b9d3d/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/NTLMScheme.java#L143 BasicScheme: https://github.com/apache/httpcomponents-client/blob/79992d832cc5d9fb4ce8307200dae844085b9d3d/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicScheme.java#L159
dagnir
force-pushed
the
dongie/apache5-fix-basic-auth
branch
from
16c039e to
2a3af9c
Compare
L-Applin
approved these changes
Nov 25, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Apache5, the auth scheme requires a specific class type for the Credentials object, otherwise the credentials will be considered missing.
NTLMScheme: https://github.com/apache/httpcomponents-client/blob/79992d832cc5d9fb4ce8307200dae844085b9d3d/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/NTLMScheme.java#L143
BasicScheme: https://github.com/apache/httpcomponents-client/blob/79992d832cc5d9fb4ce8307200dae844085b9d3d/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicScheme.java#L159
Motivation and Context
Modifications
Testing
New unit tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License