feat: add interface method annotation #3220
Open
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add method annotation in interfaces so that methods are available and recognized when the variable is declare with its interface type. For example, S3Client and S3ClientInterface.
stobrien89
requested changes
Dec 2, 2025
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Just one code question and a general question: can you show the result after running make build? Pretty sure S3ClientInterface is the only service client specific interface. Might want to skip AwsClientInterface- not sure how much value there will be in that.
| '/^\* @method (\\\\Aws\\\\Result|\\\\GuzzleHttp\\\\Promise\\\\Promise) /' | ||
| ); | ||
|
|
||
| return $interfaceUpdater->update() && $updater->update(); |
Member
There was a problem hiding this comment.
question: can we just call $interfaceUpdater->update() here and fall through to the $updater->update() call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2998
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.