Add unmanaged nodegroup support #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
unmanaged-nodegroups
branch
2 times, most recently
from
777d772 to
f9be768
Compare
cartermckinnon
force-pushed
the
unmanaged-nodegroups
branch
from
f9be768 to
4e90d25
Compare
cartermckinnon
changed the title
Contributor
|
Has this been tested on experimental infra ? |
mengqiy
reviewed
Mar 26, 2025
Contributor
mengqiy
left a comment
mengqiy
left a comment
There was a problem hiding this comment.
We will need a teardown task as well to clean up the ASG
| echo "$node_group_name is "CREATING" at $(date)" | ||
| sleep 2 | ||
| done | ||
| # TODO: do this for unmanaged nodes as well |
Contributor
There was a problem hiding this comment.
If the TODO is for unmanaged node group, we should add it in the else clause below.
| kubectl apply -f aws-auth-cm.yaml | ||
| echo "Created aws-auth ConfigMap" | ||
| # Wait for the config map to be ready | ||
| echo "Verifying aws-auth ConfigMap..." |
Contributor
There was a problem hiding this comment.
If kubectl apply exit with 0, then the aws-auth CM should have been applied successfully.
Is there a scenario that is not covered by that?
mengqiy
reviewed
Mar 26, 2025
| --arg SecurityGroup "$(jq -r '.cluster.resourcesVpcConfig.clusterSecurityGroupId' cluster.json)" \ | ||
| --arg VpcId $(jq -r '.cluster.resourcesVpcConfig.vpcId' cluster.json) \ | ||
| '$ARGS.named | to_entries | map({"ParameterKey": .key, "ParameterValue": .value})' \ | ||
| > parameters.json |
Contributor
There was a problem hiding this comment.
It would be good to cat this file if it's not super long.
Contributor
|
My comments don't have to be blocking. I'm OK merging this as is and address the comments in a follow-up PR. |
Contributor
|
LGTM |
mengqiy
approved these changes
Apr 2, 2025
mengqiy
pushed a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for creating unmanaged nodegroup(s).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.