Skip to content

Conversation

@vishaalmehrishi
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi commented Nov 24, 2025

Summary

Adding the CDK best practices tool.

Note: The starting point for the best practices is a summary of the official guidance. I'd like input on this and figured that the PR is a good place to have the discussion.

Changes

Adding a new IaC MCP server tool for CDK best practices.

User experience

AI agents will be able to serve customer requests while consulting CDK best practices for better results.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.36%. Comparing base (7bace1f) to head (295c7df).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rver/awslabs/aws_iac_mcp_server/tools/cdk_tools.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         810      811       +1     
  Lines       62171    62182      +11     
  Branches    10042    10042              
==========================================
+ Hits        56182    56191       +9     
- Misses       3734     3735       +1     
- Partials     2255     2256       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishaalmehrishi vishaalmehrishi marked this pull request as ready for review November 24, 2025 18:06
Copy link

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing on using L2s over L1?

@vishaalmehrishi
Copy link
Contributor Author

Nothing on using L2s over L1?

This is not in the official guidance, so it was not included.

Using L2s over L1s requires customers to use L2s across their stack (or with the newer changes coming, understand how to make L1s and L2s work together if there is no L2 for the service they use). I can try to add something about this, but if a customer goes looking for official guidance on this, they will not find any.

kumvprat
kumvprat previously approved these changes Nov 24, 2025
kdbrogan
kdbrogan previously approved these changes Nov 24, 2025
Copy link
Contributor

@kdbrogan kdbrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jimini55
jimini55 previously approved these changes Nov 25, 2025
@vishaalmehrishi vishaalmehrishi dismissed stale reviews from jimini55, kdbrogan, and kumvprat via 5622827 November 25, 2025 18:11
@vishaalmehrishi
Copy link
Contributor Author

After some internal discussion, I have updated the CDK best practices guidance using the official sources we discussed, plus some opinionated guidance (the potential use of CDK Nag).

I renamed the file (cdk_best_practices_official -> cdk_best_practices) since this is no longer completely official CDK guidance, which is why you will see a new file in the diff.

@theagenticguy theagenticguy added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@theagenticguy theagenticguy added this pull request to the merge queue Nov 25, 2025
Merged via the queue into awslabs:main with commit c5b0453 Nov 25, 2025
143 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in awslabs/mcp Project Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants