-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(aws-iac-mcp-server): CDK best practices tool #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-iac-mcp-server): CDK best practices tool #1832
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 90.36% 90.36% -0.01%
==========================================
Files 810 811 +1
Lines 62171 62182 +11
Branches 10042 10042
==========================================
+ Hits 56182 56191 +9
- Misses 3734 3735 +1
- Partials 2255 2256 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
praneetap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing on using L2s over L1?
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
This is not in the official guidance, so it was not included. Using L2s over L1s requires customers to use L2s across their stack (or with the newer changes coming, understand how to make L1s and L2s work together if there is no L2 for the service they use). I can try to add something about this, but if a customer goes looking for official guidance on this, they will not find any. |
kdbrogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices_official.py
Outdated
Show resolved
Hide resolved
5622827
src/aws-iac-mcp-server/awslabs/aws_iac_mcp_server/tools/cdk_best_practices.py
Show resolved
Hide resolved
|
After some internal discussion, I have updated the CDK best practices guidance using the official sources we discussed, plus some opinionated guidance (the potential use of CDK Nag). I renamed the file ( |
Summary
Adding the CDK best practices tool.
Note: The starting point for the best practices is a summary of the official guidance. I'd like input on this and figured that the PR is a good place to have the discussion.
Changes
Adding a new IaC MCP server tool for CDK best practices.
User experience
AI agents will be able to serve customer requests while consulting CDK best practices for better results.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.