Skip to content

Conversation

@vishaalmehrishi
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi commented Nov 26, 2025

…t tool execution failure

Fixes

Summary

Invoking the CDK best practices tool was resulting in the following error:

Error executing tool cdk_best_practices: Suspicious pattern detected: bypass

Turns out the agent detected "bypassed" in the guidelines and blocked tool execution. Changed this to "circumvented" and best practices tool execution works reliably now.

Changes

Changed one word in the CDK best practices

User experience

N/A

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? N

RFC issue number: N/A

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@vishaalmehrishi vishaalmehrishi added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (1b7cd2a) to head (af68faa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         813      813           
  Lines       62206    62206           
  Branches    10045    10045           
=======================================
  Hits        56215    56215           
  Misses       3736     3736           
  Partials     2255     2255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@dineshSajwan dineshSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dineshSajwan dineshSajwan added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@dineshSajwan dineshSajwan added this pull request to the merge queue Nov 26, 2025
Merged via the queue into awslabs:main with commit 0b8ff98 Nov 26, 2025
143 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in awslabs/mcp Project Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants