feat: Remove some false positives for sanitizer #1880
+1
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumvprat
requested review from
a team,
aemada-aws,
kdbrogan and
vishaalmehrishi
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
- Coverage 90.42% 90.38% -0.05%
==========================================
Files 851 843 -8
Lines 63317 62727 -590
Branches 10253 10198 -55
==========================================
- Hits 57256 56696 -560
+ Misses 3772 3746 -26
+ Partials 2289 2285 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdbrogan
previously approved these changes
Dec 4, 2025
aemada-aws
previously approved these changes
Dec 4, 2025
|
|
||
|
|
||
| # Common prompt injection patterns | ||
| ATTACK_PATTERNS = [ |
Member
There was a problem hiding this comment.
Which patterns are problematic?
Contributor
Author
There was a problem hiding this comment.
These patterns are detected on tool response.
As the tool response is based on official documentation, this check is not necessary.
Member
There was a problem hiding this comment.
You would you consider leaving only the ignore previous instructions?
kdbrogan
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Remove false positives for sanitizer
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.