Skip to content

Conversation

@naikvaib
Copy link
Member

@naikvaib naikvaib commented Dec 4, 2025

Summary

Changes

Implementation of EMR Serverless (EMR-S) Tools for jobs and applications compliance with MCP resource management standards.

Please provide a summary of what's being changed

  • EMR Serverless Application and Job Run Tools introduced
  • EMR Serverless Application and Job Run handlers properly implement MCP tagging
  • Resource creation automatically adds MCP management tags (ManagedBy: DataprocessingMcpServer, ResourceType, CreatedAt)
  • Update/delete operations verify MCP management before allowing modifications
  • Implementation follows same patterns as Athena, Glue, and EMR-EC2 services
  • Comprehensive test coverage exists for all tagging scenarios
  • CUSTOM_TAGS environment variable support is properly implemented

User experience

Before: Users had no support to work on EMR Serverless functionality

After: Users can confidently use EMR Serverless tools knowing that:

  • All created resources are properly tagged for MCP management
  • Resources created outside MCP cannot be accidentally modified/deleted
  • Tagging behavior can be customized via CUSTOM_TAGS environment variable
  • Full compatibility with existing Athena, Glue, and EMR-EC2 resource management patterns

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? No

RFC issue number: #1201

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@naikvaib naikvaib changed the title Emr s feat(aws-data-processing-mcp-server): Add Support for EMR-S Job and Application Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 89.76190% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (d6344f8) to head (9347ed6).

Files with missing lines Patch % Lines
...handlers/emr/emr_serverless_application_handler.py 90.35% 9 Missing and 10 partials ⚠️
.../aws_dataprocessing_mcp_server/utils/aws_helper.py 9.52% 19 Missing ⚠️
...ver/handlers/emr/emr_serverless_job_run_handler.py 96.06% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   90.42%   90.19%   -0.23%     
==========================================
  Files         851      698     -153     
  Lines       63317    55849    -7468     
  Branches    10253     9315     -938     
==========================================
- Hits        57254    50373    -6881     
+ Misses       3772     3358     -414     
+ Partials     2291     2118     -173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

1 participant