fix: Return a map when dissociating a record basis field #1009
+58
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Nov 8, 2025
| (sci.impl.records/->record-impl '~rec-type ~rec-type (var ~record-name) | ||
| (sci.impl.records/->record-impl '~rec-type | ||
| ~rec-type | ||
| (set (map keyword ~keys)) |
Collaborator
There was a problem hiding this comment.
I think creating the set of keywords doesn't need to happen at runtime in the constructor, but can happen at macro time, once, instead.
Collaborator
There was a problem hiding this comment.
In fact, we already have this, kind of, it's called keys, it's already a vector of keywords so you can introduce another local there, called key-set by turning that into a set
Collaborator
There was a problem hiding this comment.
I pushed one minor simplification to the existing code: arg-syms and fields were basically already the same thing so there was some unnecessary code
Collaborator
There was a problem hiding this comment.
Tried to resolve the conflict manually git the Github UI. Hopefully didn't make any mistakes there :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes babashka/babashka#1886.
Please answer the following questions and leave the below in as part of your PR.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions