Feat add direct providers esim #3857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotfix: support legacy customfields
kaioken
requested changes
Apr 24, 2025
| ) { | ||
| } | ||
|
|
||
| public function applyEsim($options): array |
| use Kanvas\Connectors\ESimGo\Client; | ||
| use Kanvas\Exceptions\ValidationException; | ||
|
|
||
| class ESimGoService |
Collaborator
Author
There was a problem hiding this comment.
Yes but for Esimgo, you asked to keep them separate, each encapsulated in his own connector
| } | ||
|
|
||
| // Order related functions | ||
| public function createOrder($options): array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Description
Please include a summary of the changes and the related issue. Highlight key points of the PR, any relevant information, and reasons for making the change.
Related Issue
A link to the ticket or issue that this PR is related to.(if applicable)
Checklist
A checklist of things that should be done before merging this PR. Linked to the ticket or issue that this PR is related to.(if applicable)
Screenshots (if applicable)
Provide screenshots of impactful changes you have made so that the reviewer can quickly understand the changes.